lidavidm commented on a change in pull request #12706:
URL: https://github.com/apache/arrow/pull/12706#discussion_r839818210
##########
File path: cpp/src/arrow/array/array_test.cc
##########
@@ -78,6 +78,14 @@ class TestArray : public ::testing::Test {
MemoryPool* pool_;
};
+
+TEST_F(TestArray, ValidateFullNullable) {
+ auto f1 = field("f1", int32(), /*nullable=*/false);
+ auto type1 = std::make_shared<ListType>(f1);
Review comment:
nit: just use `auto ty = list(f1);`
##########
File path: cpp/src/arrow/array/validate.cc
##########
@@ -580,7 +582,7 @@ struct ValidateArrayImpl {
template <typename ListType>
Status ValidateListLike(const ListType& type) {
const ArrayData& values = *data.child_data[0];
- const Status child_valid = RecurseInto(values);
+ const Status child_valid = RecurseInto(values,
/**/type.value_field()->nullable());
Review comment:
```suggestion
const Status child_valid = RecurseInto(values,
type.value_field()->nullable());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
