alamb opened a new pull request #8009:
URL: https://github.com/apache/arrow/pull/8009


   I added two test cases in https://github.com/apache/arrow/pull/8007, which 
increased coverage. However, upon further review, I noticed the choice of 
parameters to hit edge conditions didn't cover the string data types.
   
   Rather than adding a bunch more copies of basically the same test to add new 
parameters for different tests, I instead propose using the same set of 
parameters for all data types and drive the tests using a table in this PR. 
   
   It makes the test logic slightly harder to follow, in my opinion, but it 
does increase coverage
   
   Draft PR until the disposition of https://github.com/apache/arrow/pull/8007 
is decided


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to