emkornfield commented on a change in pull request #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r841093107
##########
File path: cpp/src/arrow/filesystem/gcsfs.cc
##########
@@ -536,8 +546,7 @@ class GcsFileSystem::Impl {
gcs::ReadFromOffset
offset) {
auto stream = client_.ReadObject(path.bucket, path.object, generation,
offset);
ARROW_GCS_RETURN_NOT_OK(stream.status());
- return std::make_shared<GcsInputStream>(std::move(stream), path,
gcs::Generation(),
- offset, client_);
+ return std::make_shared<GcsInputStream>(std::move(stream), path,
generation, client_);
Review comment:
I looked at the GCS code and it does appear to keep the ReadAt offset to
return for tell but I might have missed something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
