jackwener commented on a change in pull request #2142:
URL: https://github.com/apache/arrow-datafusion/pull/2142#discussion_r841232235
##########
File path: datafusion/core/tests/sql/expr.rs
##########
@@ -280,6 +280,47 @@ async fn query_scalar_minus_array() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn test_string_concat_operator() -> Result<()> {
+ let ctx = SessionContext::new();
+ // concat 2 strings
+ let sql = "SELECT 'aa' || 'b'";
+ let actual = execute_to_batches(&ctx, sql).await;
+ let expected = vec![
+ "+-------------------------+",
+ "| Utf8(\"aa\") || Utf8(\"b\") |",
+ "+-------------------------+",
+ "| aab |",
+ "+-------------------------+",
+ ];
+ assert_batches_eq!(expected, &actual);
+
+ // concat 4 strings as a string concat pipe.
+ let sql = "SELECT 'aa' || 'b' || 'cc' || 'd'";
+ let expected = vec![
+ "+----------------------------------------------------+",
+ "| Utf8(\"aa\") || Utf8(\"b\") || Utf8(\"cc\") || Utf8(\"d\") |",
+ "+----------------------------------------------------+",
+ "| aabccd |",
+ "+----------------------------------------------------+",
+ ];
+ let actual = execute_to_batches(&ctx, sql).await;
+ assert_batches_eq!(expected, &actual);
+
+ // concat 3 strings with one is NULL
+ let sql = "SELECT 'aa' || NULL || 'd'";
+ let expected = vec![
+ "+---------------------------------------+",
+ "| Utf8(\"aa\") || Utf8(NULL) || Utf8(\"d\") |",
+ "+---------------------------------------+",
+ "| aad |",
+ "+---------------------------------------+",
+ ];
+ let actual = execute_to_batches(&ctx, sql).await;
+ assert_batches_eq!(expected, &actual);
+ Ok(())
Review comment:
I think we can add more case test.
For example
```
string || non-string or non-string || string
---like---
input : 'Value: ' || 42
output : Value: 42
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
