joosthooz commented on code in PR #12609:
URL: https://github.com/apache/arrow/pull/12609#discussion_r841872754
##########
cpp/src/arrow/util/tracing_internal.h:
##########
@@ -146,6 +158,17 @@ opentelemetry::trace::StartSpanOptions
SpanOptionsWithParent(
return st;
\
})
+#define PROPAGATE_SPAN_TO_GENERATOR(generator) \
Review Comment:
> Propagate -> The generator "is a part of a larger activity"
Yes, in this case, the span is not ended if the generator finishes. It is
just needed so that any spans created in the asynchronously running code
(possibly in other threads) do not end up becoming orphan spans in a separate
trace.
##########
cpp/src/arrow/util/tracing_internal.h:
##########
@@ -146,6 +158,17 @@ opentelemetry::trace::StartSpanOptions
SpanOptionsWithParent(
return st;
\
})
+#define PROPAGATE_SPAN_TO_GENERATOR(generator) \
Review Comment:
> Propagate -> The generator "is a part of a larger activity"
Yes, in this case, the span is not ended if the generator finishes. It is
just needed so that any spans created in the asynchronously running code
(possibly in other threads) do not end up becoming orphan spans in a separate
trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
