alamb commented on code in PR #2142:
URL: https://github.com/apache/arrow-datafusion/pull/2142#discussion_r842003689
##########
datafusion/core/src/sql/planner.rs:
##########
@@ -1311,6 +1311,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
BinaryOperator::PGRegexNotIMatch => Ok(Operator::RegexNotIMatch),
BinaryOperator::BitwiseAnd => Ok(Operator::BitwiseAnd),
BinaryOperator::BitwiseOr => Ok(Operator::BitwiseOr),
+ BinaryOperator::StringConcat => Ok(Operator::StringConcat),
Review Comment:
Since we already have a function for `concat` I think you could simply plan
`foo || bar` into a function call `concat(foo, bar)`
Something like
```suggestion
BinaryOperator::StringConcat => return Ok(Expr::ScalarFunction {
fun: functions::BuiltinScalarFunction::Concat,
args: vec![left, right],
}),
```
Then you would probably need no additional changes in this PR (just keep the
tests)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
