kiszk commented on a change in pull request #8011:
URL: https://github.com/apache/arrow/pull/8011#discussion_r473904805
##########
File path: go/arrow/type_traits_decimal128.go
##########
@@ -39,8 +40,13 @@ func (decimal128Traits) BytesRequired(n int) int { return
Decimal128SizeBytes *
// PutValue
func (decimal128Traits) PutValue(b []byte, v decimal128.Num) {
- binary.LittleEndian.PutUint64(b[:8], uint64(v.LowBits()))
- binary.LittleEndian.PutUint64(b[8:], uint64(v.HighBits()))
+ if runtime.GOARCH == "s390x" {
+ binary.BigEndian.PutUint64(b[:8], uint64(v.LowBits()))
Review comment:
Can we use [this
convention](https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/basic_decimal.cc#L145-L154)
across languages? In other words, `LowBits()` always keeps lower 64-bits
regardless of endian. `HighBits()` keeps higher 64-bits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
