lidavidm commented on code in PR #12719:
URL: https://github.com/apache/arrow/pull/12719#discussion_r842722964
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -316,8 +316,8 @@ gaflight_client_list_flights(GAFlightClient *client,
}
std::unique_ptr<arrow::flight::FlightListing> flight_listing;
auto status = flight_client->ListFlights(*flight_options,
- *flight_criteria,
- &flight_listing);
+ *flight_criteria
+ ).Value(&flight_listing);
Review Comment:
Similarly, this (and below) would benefit from splitting the result and the
status into separate statements so that we can keep a consistent style.
##########
c_glib/arrow-flight-glib/client.cpp:
##########
@@ -251,12 +251,12 @@ gaflight_client_new(GAFlightLocation *location,
arrow::Status status;
if (options) {
const auto flight_options = gaflight_client_options_get_raw(options);
- status = arrow::flight::FlightClient::Connect(*flight_location,
- *flight_options,
- &flight_client);
+ arrow::Result<std::unique_ptr<arrow::flight::FlightClient>> result =
arrow::flight::FlightClient::Connect(*flight_location,
+ *flight_options);
+ status = std::move(result).Value(&flight_client);
Review Comment:
A few things:
There's an extra space at the beginning of the line.
Why not use `auto` as before and keep things aligned, in a consistent style
with everything else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
