sanjibansg commented on code in PR #12755:
URL: https://github.com/apache/arrow/pull/12755#discussion_r843536959
##########
cpp/src/arrow/compute/exec/expression_benchmark.cc:
##########
@@ -92,6 +112,11 @@ auto guarantee = and_(equal(field_ref("a"),
literal(int64_t(99))),
auto guarantee_dictionary = and_(equal(field_ref("a"),
literal(ninety_nine_dict)),
equal(field_ref("b"),
literal(ninety_nine_dict)));
+auto expression_with_copy =
+ and_(less(field_ref("x"), literal(20)), greater(field_ref("x"),
literal(0)));
+
+auto expression_without_copy = field_ref("x");
Review Comment:
Added the other expressions. Thanks!
##########
cpp/src/arrow/compute/exec/expression_benchmark.cc:
##########
@@ -119,6 +144,11 @@ BENCHMARK_CAPTURE(BindAndEvaluate, nested_array,
field_ref(FieldRef("struct_arr", "float")));
BENCHMARK_CAPTURE(BindAndEvaluate, nested_scalar,
field_ref(FieldRef("struct_scalar", "float")));
-
+BENCHMARK_CAPTURE(BatchedExecution, execution_with_copy, expression_with_copy)
+ ->RangeMultiplier(10)
+ ->Range(1, 10000000);
+BENCHMARK_CAPTURE(BatchedExecution, execution_without_copy,
expression_without_copy)
+ ->RangeMultiplier(10)
+ ->Range(1, 10000000);
Review Comment:
Made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
