edponce commented on code in PR #12460:
URL: https://github.com/apache/arrow/pull/12460#discussion_r844297241
##########
cpp/src/arrow/compute/api_vector.h:
##########
@@ -188,6 +188,29 @@ class ARROW_EXPORT PartitionNthOptions : public
FunctionOptions {
NullPlacement null_placement;
};
+/// \brief Options for cumulative sum function
+class ARROW_EXPORT CumulativeSumOptions : public FunctionOptions {
+ public:
+ // Default `start` value is of type Int8 to allow type casting and
compatibility rules
+ // to use the type of the function values.
Review Comment:
Oops, this was an old comment. Not true nor relevant anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]