cyb70289 commented on a change in pull request #7963:
URL: https://github.com/apache/arrow/pull/7963#discussion_r474660357
##########
File path: cpp/src/arrow/compute/kernels/aggregate_test.cc
##########
@@ -685,5 +687,10 @@ TYPED_TEST(TestFloatingModeKernel, Floats) {
this->AssertModeIsNull("[]");
}
+TEST_F(TestInt8ModeKernelValueRange, Basics) {
Review comment:
Old code uses std::unordered_map, new code uses an vector with
calculated size. Just to make sure boundary condition is correctly handled, so
test with the minimal(-128) and maximal(127) value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
