jorisvandenbossche commented on code in PR #12816:
URL: https://github.com/apache/arrow/pull/12816#discussion_r845062725
##########
cpp/src/arrow/adapters/orc/adapter_test.cc:
##########
@@ -406,6 +423,10 @@ TEST(TestAdapterRead, ReadIntAndStringFileMultipleStripes)
{
// Trivial
+class TestORCWriterTrivialNoWrite : public ::testing::Test {};
+TEST_F(TestORCWriterTrivialNoWrite, noWrite) {
+ TestORCWriterNoWrite(kDefaultSmallMemStreamSize / 16);
Review Comment:
Is there a reason to not just put the test code here instead of going
through the helper function? The other tests often use some helper function,
but that is maybe always because it is used multiple times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
