jorisvandenbossche commented on code in PR #12811:
URL: https://github.com/apache/arrow/pull/12811#discussion_r845292683
##########
python/pyarrow/tests/parquet/test_dataset.py:
##########
@@ -1531,8 +1531,8 @@ def test_dataset_read_dictionary(tempdir,
use_legacy_dataset):
t1 = pa.table([[util.rands(10) for i in range(5)] * 10], names=['f0'])
t2 = pa.table([[util.rands(10) for i in range(5)] * 10], names=['f0'])
# TODO pass use_legacy_dataset (need to fix unique names)
- pq.write_to_dataset(t1, root_path=str(path))
- pq.write_to_dataset(t2, root_path=str(path))
+ pq.write_to_dataset(t1, root_path=str(path), use_legacy_dataset=True)
+ pq.write_to_dataset(t2, root_path=str(path), use_legacy_dataset=True)
Review Comment:
Same here as my comment above
(https://github.com/apache/arrow/pull/12811/files#r845291213), as the TODO
comment also indicates: calling this twice with `use_legacy_dataset=False`
would overwrite the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
