paleolimbot commented on code in PR #12610:
URL: https://github.com/apache/arrow/pull/12610#discussion_r846182491
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -309,6 +309,35 @@ register_bindings_duration <- function() {
build_expr("cast", x, options = cast_options(to_type = duration(unit =
"s")))
})
+ register_binding("dminutes", function(x=1) {
+ dmin_int64 <- Expression$create("cast", x * 60, options =
cast_options(to_type = int64()))
+ build_expr("cast", dmin_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dhours", function(x=1) {
+ dhours_int64 <- Expression$create("cast", x * 3600, options =
cast_options(to_type = int64()))
+ build_expr("cast", dhours_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("ddays", function(x=1) {
Review Comment:
```suggestion
register_binding("ddays", function(x = 1) {
```
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -309,6 +309,35 @@ register_bindings_duration <- function() {
build_expr("cast", x, options = cast_options(to_type = duration(unit =
"s")))
})
+ register_binding("dminutes", function(x=1) {
+ dmin_int64 <- Expression$create("cast", x * 60, options =
cast_options(to_type = int64()))
+ build_expr("cast", dmin_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dhours", function(x=1) {
Review Comment:
```suggestion
register_binding("dhours", function(x = 1) {
```
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -309,6 +309,35 @@ register_bindings_duration <- function() {
build_expr("cast", x, options = cast_options(to_type = duration(unit =
"s")))
})
+ register_binding("dminutes", function(x=1) {
Review Comment:
```suggestion
register_binding("dminutes", function(x = 1) {
```
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -309,6 +309,35 @@ register_bindings_duration <- function() {
build_expr("cast", x, options = cast_options(to_type = duration(unit =
"s")))
})
+ register_binding("dminutes", function(x=1) {
+ dmin_int64 <- Expression$create("cast", x * 60, options =
cast_options(to_type = int64()))
+ build_expr("cast", dmin_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dhours", function(x=1) {
+ dhours_int64 <- Expression$create("cast", x * 3600, options =
cast_options(to_type = int64()))
+ build_expr("cast", dhours_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("ddays", function(x=1) {
+ ddays_int64 <- Expression$create("cast", x * 86400, options =
cast_options(to_type = int64()))
+ build_expr("cast", ddays_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dweeks", function(x=1) {
Review Comment:
```suggestion
register_binding("dweeks", function(x = 1) {
```
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -309,6 +309,35 @@ register_bindings_duration <- function() {
build_expr("cast", x, options = cast_options(to_type = duration(unit =
"s")))
})
+ register_binding("dminutes", function(x=1) {
+ dmin_int64 <- Expression$create("cast", x * 60, options =
cast_options(to_type = int64()))
+ build_expr("cast", dmin_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dhours", function(x=1) {
+ dhours_int64 <- Expression$create("cast", x * 3600, options =
cast_options(to_type = int64()))
+ build_expr("cast", dhours_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("ddays", function(x=1) {
+ ddays_int64 <- Expression$create("cast", x * 86400, options =
cast_options(to_type = int64()))
+ build_expr("cast", ddays_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dweeks", function(x=1) {
+ dweeks_int64 <- Expression$create("cast", x * 604800, options =
cast_options(to_type = int64()))
+ build_expr("cast", dweeks_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dmonths", function(x=1) {
+ dmonths_int64 <- Expression$create("cast", x * 2629800, options =
cast_options(to_type = int64()))
+ build_expr("cast", dmonths_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dyears", function(x=1) {
Review Comment:
```suggestion
register_binding("dyears", function(x = 1) {
```
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -309,6 +309,35 @@ register_bindings_duration <- function() {
build_expr("cast", x, options = cast_options(to_type = duration(unit =
"s")))
})
+ register_binding("dminutes", function(x=1) {
+ dmin_int64 <- Expression$create("cast", x * 60, options =
cast_options(to_type = int64()))
+ build_expr("cast", dmin_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dhours", function(x=1) {
+ dhours_int64 <- Expression$create("cast", x * 3600, options =
cast_options(to_type = int64()))
+ build_expr("cast", dhours_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("ddays", function(x=1) {
+ ddays_int64 <- Expression$create("cast", x * 86400, options =
cast_options(to_type = int64()))
+ build_expr("cast", ddays_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dweeks", function(x=1) {
+ dweeks_int64 <- Expression$create("cast", x * 604800, options =
cast_options(to_type = int64()))
+ build_expr("cast", dweeks_int64, options = list(to_type = duration(unit =
"s")))
+ })
+
+ register_binding("dmonths", function(x=1) {
Review Comment:
```suggestion
register_binding("dmonths", function(x = 1) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
