lidavidm commented on code in PR #12812:
URL: https://github.com/apache/arrow/pull/12812#discussion_r846623192
##########
cpp/src/arrow/ipc/writer.cc:
##########
@@ -263,6 +263,14 @@ class RecordBatchSerializer {
out_->body_length = offset - buffer_start_offset_;
DCHECK(bit_util::IsMultipleOf8(out_->body_length));
+ // copy given record batch's schema metadata to the serializer for
serialization
+ auto const &metadata = batch.schema()->metadata();
Review Comment:
For the bindings: we can tackle them separately. CI will catch us if we make
any breaking changes that need to be handled here. It's only Python/R/GLib
(Ruby) we have to worry about (Java/Go have a few bindings I think but not at
this level).
For the APIs: I would prefer adding overloads. CC @pitrou for opinions too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
