andygrove commented on pull request #8029: URL: https://github.com/apache/arrow/pull/8029#issuecomment-678728434
Yes, exactly. We could do more efficient things in the future such as perform sorts in parallel and then do a sort-merge join on the results. On Sat, Aug 22, 2020, 10:19 PM Jorge Leitao <notificati...@github.com> wrote: > *@jorgecarleitao* commented on this pull request. > ------------------------------ > > In rust/datafusion/src/execution/physical_plan/sort.rs > <https://github.com/apache/arrow/pull/8029#discussion_r475168077>: > > > @@ -61,44 +61,28 @@ impl ExecutionPlan for SortExec { > self.input.schema().clone() > } > > - fn partitions(&self) -> Result<Vec<Arc<dyn Partition>>> { > - Ok(vec![ > - (Arc::new(SortPartition { > - input: self.input.partitions()?, > - expr: self.expr.clone(), > - schema: self.schema(), > - concurrency: self.concurrency, > - })), > - ]) > + /// Get the output partitioning of this plan > + fn output_partitioning(&self) -> Partitioning { > + Partitioning::UnknownPartitioning(1) > > To make sure I am following: this is 1 because we pull everything to the > same partition in a sort via Merge. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/8029#pullrequestreview-472977856>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAHEBRGZMBCN76CQNAE6RDTSCCKF3ANCNFSM4QIKKJ7Q> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
