jonkeane commented on PR #12862: URL: https://github.com/apache/arrow/pull/12862#issuecomment-1096697300
Thanks for this! The change itself looks good. I know there aren't existing tests for this in https://github.com/apache/arrow/blob/master/dev/archery/archery/crossbow/tests/test_core.py (or elsewhere), but it would be good for us to add them as we make additions like this so that we can see what behavior we're expecting | what might break this. Would you mind adding a handful of tests (at least the ones you have in the PR comment...)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
