tustvold commented on code in PR #1552:
URL: https://github.com/apache/arrow-rs/pull/1552#discussion_r848602337
##########
arrow/src/record_batch.rs:
##########
@@ -101,23 +100,21 @@ impl RecordBatch {
.iter()
.map(|field| new_empty_array(field.data_type()))
.collect();
- RecordBatch { schema, columns }
+
+ RecordBatch {
+ schema,
+ columns,
+ row_count: 0,
+ }
}
/// Validate the schema and columns using [`RecordBatchOptions`]. Returns
an error
- /// if any validation check fails.
- fn validate_new_batch(
- schema: &SchemaRef,
- columns: &[ArrayRef],
+ /// if any validation check fails, otherwise returns the created
[`RecordBatch`]
+ fn try_new_impl(
Review Comment:
I'm not really sure why we need a separate method for this, but I avoided
changing it to keep the diff down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
