[GitHub] [arrow] ViniciusSouzaRoque commented on a diff in pull request #12716: ARROW-16031: [C++][Gandiva] Fix Soundex errors generate

[GitBox]

ViniciusSouzaRoque commented on code in PR #12716:
URL: https://github.com/apache/arrow/pull/12716#discussion_r848764946


##########
cpp/src/gandiva/precompiled/string_ops_test.cc:
##########
@@ -2310,12 +2310,43 @@ TEST(TestStringOps, TestFromHex) {
       ::testing::HasSubstr("Error parsing hex string, one or more bytes are 
not valid."));
   ctx.Reset();
 }
+
 TEST(TestStringOps, TestSoundex) {
   gandiva::ExecutionContext ctx;
   auto ctx_ptr = reinterpret_cast<int64_t>(&ctx);
   int32_t out_len = 0;
   const char* out;
 
+  out = soundex_utf8(ctx_ptr, "Robert", 6, &out_len);

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org