tustvold commented on code in PR #2218:
URL: https://github.com/apache/arrow-datafusion/pull/2218#discussion_r848817420
##########
datafusion/physical-expr/src/physical_expr.rs:
##########
@@ -51,23 +47,15 @@ pub trait PhysicalExpr: Send + Sync + Display + Debug {
batch: &RecordBatch,
selection: &BooleanArray,
) -> Result<ColumnarValue> {
- if selection.iter().all(|b| b == Some(true)) {
+ let filter_count = selection
Review Comment:
> also avoided the scatter path in case of all values being true.
You could inspect the length of the returned filtered array instead of
counting the bits twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
