jorgecarleitao commented on a change in pull request #8033:
URL: https://github.com/apache/arrow/pull/8033#discussion_r475270612



##########
File path: rust/datafusion/src/logicalplan.rs
##########
@@ -713,6 +718,9 @@ impl fmt::Debug for Expr {
         match self {
             Expr::Alias(expr, alias) => write!(f, "{:?} AS {}", expr, alias),
             Expr::Column(name) => write!(f, "#{}", name),
+            Expr::ScalarVariable(variable_names) => {
+                write!(f, "#{}", variable_names.join("."))

Review comment:
       this naming is already being used by columns (one line above). Doesn't 
this make it confusing?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to