raulcd commented on code in PR #12854: URL: https://github.com/apache/arrow/pull/12854#discussion_r849503021
########## python/examples/minimal_build/build_conda.sh: ########## @@ -28,8 +28,6 @@ CPP_BUILD_DIR=$HOME/arrow-cpp-build ARROW_ROOT=/arrow PYTHON=3.10 -git clone --depth=100 https://github.com/apache/arrow.git /arrow - #---------------------------------------------------------------------- Review Comment: Yes, this is used only on the minimal build examples for conda. I am not entirely sure about using the `ci/scripts/install_conda.sh`. The current script does not only install conda but contains all the steps for the minimal build in order to help debug basic build environments, based on the `README.md`: ``` This directory shows how to bootstrap a local build from source on Linux with an eye toward maximum portability across different Linux distributions. This may help for contributors debugging build issues caused by their local environments. ``` In my opinion splitting the `install/build` steps on two different scripts, the install on `ci/scripts/install_conda.sh` and the build on `python/examples/minimal_build/build_conda.sh` might be confusing for the purpose of debugging minimal builds. I also understand that having two "install_conda" scripts is also not ideal. Is your idea to have these two steps split on two different scripts? If that's the case I would propose to include it on a different ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
