alistaire47 commented on code in PR #12867:
URL: https://github.com/apache/arrow/pull/12867#discussion_r849645179
##########
r/tests/testthat/test-dplyr-summarize.R:
##########
@@ -341,10 +337,9 @@ test_that("median()", {
tbl,
warning = "median\\(\\) currently returns an approximate median in Arrow"
)
- local_edition(3)
-})
+}, classes = "arrow.median.approximate"))
Review Comment:
Yeah, I think this was an R 4.0 thing. Ironically I was playing around with
similar ideas at the same time in [rror](https://github.com/alistaire47/rror).
Maybe there's still some value to that package, but I suspect it's mostly
obsolete now. I should really write a blog post about the concepts, though;
nobody classes conditions enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
