pitrou commented on code in PR #12055:
URL: https://github.com/apache/arrow/pull/12055#discussion_r849816202
##########
cpp/src/arrow/chunked_array.h:
##########
@@ -182,6 +183,7 @@ class ARROW_EXPORT ChunkedArray {
std::shared_ptr<DataType> type_;
private:
+ std::unique_ptr<internal::ChunkResolver> chunk_resolver_;
Review Comment:
Again, you can easily define a move constructor for `ChunkResolver` just as
you did for the copy constructor, so I'm not sure what the actual difficulty is.
Something like:
```c++
ChunkResolver(ChunkResolver&& other)
: offsets_(std::move(other.offsets_)),
cached_chunk_(other.cached_chunk_.load()) {}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]