dragosmg commented on code in PR #12855:
URL: https://github.com/apache/arrow/pull/12855#discussion_r850231996
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -354,21 +354,21 @@ register_bindings_duration <- function() {
}
register_bindings_duration_helpers <- function() {
- register_binding("dseconds", function(x = 1) {
+ make_duration <- function(x, unit) {
Review Comment:
Thanks for this and sorry to be a pain. I think `make_duration()` can be a
standalone function, it doesn't need to be a binding since there is no
`lubridate` equivalent to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
