michalursa commented on code in PR #12872: URL: https://github.com/apache/arrow/pull/12872#discussion_r851079678
########## cpp/src/arrow/compute/light_array_test.cc: ########## @@ -0,0 +1,504 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/light_array.h" + +#include <gtest/gtest.h> + +#include "arrow/compute/exec/test_util.h" +#include "arrow/testing/generator.h" +#include "arrow/testing/gtest_util.h" +#include "arrow/type.h" + +namespace arrow { +namespace compute { + +const std::vector<std::shared_ptr<DataType>> kSampleFixedDataTypes = { + int8(), int16(), int32(), int64(), uint8(), + uint16(), uint32(), uint64(), decimal128(38, 6), decimal256(76, 6)}; +const std::vector<std::shared_ptr<DataType>> kSampleBinaryTypes = { + utf8(), binary() /*, large_utf8(), large_binary()*/}; Review Comment: Also, dictionary type is not supported in KeyColumn... (hash table either works with indices from dictionary or decoded values). Once new hash join is ready, there will be a follow up change to port dictionary type support from old hash join to new hash join, which will not have it initially. At this point some of the code from this PR may need to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
