viirya commented on code in PR #1566:
URL: https://github.com/apache/arrow-rs/pull/1566#discussion_r851356037
##########
arrow/src/ipc/writer.rs:
##########
@@ -175,13 +186,37 @@ impl IpcDataGenerator {
)?;
}
}
+ _ => (),
Review Comment:
Hmm, I guess that it doesn't just returning an error, is because if no
dictionaries exist inside the fields of these nested types, then the ipc writer
still can work. To return an error for dictionaries existing inside unsupported
nested types, we need to look into them as supported types, so it's basically
almost near to implement them.
I may take some time continuing the work to add more supports (map, etc)
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
