tustvold commented on code in PR #1571:
URL: https://github.com/apache/arrow-rs/pull/1571#discussion_r851723775
##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -133,7 +133,7 @@ fn generic_substring<OffsetSize: StringOffsetSizeTrait>(
pub fn substring(
array: &dyn Array,
start: i64,
- length: &Option<u64>,
+ length: Option<&u64>,
Review Comment:
I'll get a PR up to do shortly, I was a bit too trigger happy on the merge,
I think there is a case above as well :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
