HaoYang670 commented on code in PR #1577:
URL: https://github.com/apache/arrow-rs/pull/1577#discussion_r852011677
##########
arrow/benches/string_kernels.rs:
##########
@@ -39,10 +39,10 @@ fn add_benchmark(c: &mut Criterion) {
let str_len = 1000;
let arr_string = create_string_array_with_len::<i32>(size, 0.0, str_len);
- let start = 0;
+ let start = 1;
Review Comment:
The validation checking is only enabled when `start !=0` or `length !=
None`. So there is no performance cost for the first micro-bench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
