lidavidm commented on code in PR #12672: URL: https://github.com/apache/arrow/pull/12672#discussion_r852103722
########## cpp/src/arrow/engine/substrait/util.h: ########## @@ -0,0 +1,47 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <memory> +#include <string> +#include <vector> +#include "arrow/compute/type_fwd.h" +#include "arrow/engine/api.h" +#include "arrow/util/iterator.h" +#include "arrow/util/optional.h" + +namespace arrow { + +namespace engine { + +/// \brief Retrieve a RecordBatchReader from a Substrait plan in JSON. +ARROW_ENGINE_EXPORT Result<std::shared_ptr<RecordBatchReader>> GetRecordBatchReader( + std::string& substrait_json); + +/// \brief Retrieve a RecordBatchReader from a Substrait plan in Buffer. +ARROW_ENGINE_EXPORT Result<std::shared_ptr<RecordBatchReader>> GetRecordBatchReader( Review Comment: And again, I think any use of `Buffer` here in a parameter, method name, or docstring is confusing at best, we should clarify what exactly it's meant to be -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
