pitrou commented on code in PR #12755:
URL: https://github.com/apache/arrow/pull/12755#discussion_r852227743
##########
cpp/src/arrow/compute/exec/expression_benchmark.cc:
##########
@@ -69,6 +70,26 @@ static void SimplifyFilterWithGuarantee(benchmark::State&
state, Expression filt
}
}
+static void ExecuteScalarExpressionOverhead(benchmark::State& state,
Expression expr) {
+ const auto rows_per_batch = static_cast<int32_t>(state.range(0));
+ const auto num_batches = 1000000 / rows_per_batch;
+
+ ExecContext ctx;
+ auto dataset_schema = schema({
+ field("x", int64()),
+ });
+ ExecBatch input({Datum(ConstantArrayGenerator::Int64(rows_per_batch, 5))},
+ /*length=*/rows_per_batch);
+
+ ASSIGN_OR_ABORT(auto bound, expr.Bind(*dataset_schema));
+ for (auto _ : state) {
+ for (int it = 0; it < num_batches; ++it)
+ ABORT_NOT_OK(ExecuteScalarExpression(bound, input, &ctx).status());
+ }
+ state.counters["rows_per_second"] = benchmark::Counter(
+ state.iterations() * num_batches * rows_per_batch,
benchmark::Counter::kIsRate);
+}
Review Comment:
Hmm, ok, can we also add a `batches_per_second` counter? For a trivial
expression it may give more meaningful information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
