ArianaVillegas commented on code in PR #12625: URL: https://github.com/apache/arrow/pull/12625#discussion_r852456981
########## cpp/src/arrow/filesystem/filesystem.h: ########## @@ -186,12 +198,16 @@ class ARROW_EXPORT FileSystem : public std::enable_shared_from_this<FileSystem> virtual Result<FileInfo> GetFileInfo(const std::string& path) = 0; /// Same, for many targets at once. virtual Result<FileInfoVector> GetFileInfo(const std::vector<std::string>& paths); + /// Get file for file selector + virtual Result<FileInfoVector> GetFileInfo(const FileSelector& select); /// Same, according to a selector. /// /// The selector's base directory will not be part of the results, even if /// it exists. /// If it doesn't exist, see `FileSelector::allow_not_found`. - virtual Result<FileInfoVector> GetFileInfo(const FileSelector& select) = 0; + virtual Result<FileInfoVector> GetFileInfoDir(const FileSelector& select) = 0; Review Comment: I made `GetFileInfoDir` and `GetFileInfoGlob` methods protected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
