emkornfield commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r852616552
##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -568,7 +574,46 @@ TEST_F(GcsIntegrationTest, GetFileInfoBucket) {
ASSERT_RAISES(Invalid, fs->GetFileInfo("gs://" + PreexistingBucketName()));
}
-TEST_F(GcsIntegrationTest, GetFileInfoObject) {
+TEST_F(GcsIntegrationTest, GetFileInfoObjectWithNestedStructure) {
+ auto fs = GcsFileSystem::Make(TestGcsOptions());
+ constexpr auto kObjectName =
"test-object-dir/some_other_dir/another_dir/foo";
+ ASSERT_OK_AND_ASSIGN(
+ auto output,
+ fs->OpenOutputStream(PreexistingBucketPath() + kObjectName,
/*metadata=*/{}));
+ const auto data = std::string(kLoremIpsum);
+ ASSERT_OK(output->Write(data.data(), data.size()));
+ ASSERT_OK(output->Close());
+
+ ASSERT_OK_AND_ASSIGN(output, fs->OpenOutputStream(PreexistingBucketPath() +
+
"test-object-dir/some_other_dir0",
Review Comment:
added a comment.
##########
dev/archery/archery/cli.py:
##########
@@ -183,6 +183,8 @@ def _apply_options(cmd, options):
@click.option("--with-r", default=None, type=BOOL,
help="Build the Arrow R extensions. This is not a CMake option, "
"it will toggle required options")
[email protected]("--with-gcs", default=None, type=BOOL,
Review Comment:
yep. done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
