alamb commented on code in PR #2261:
URL: https://github.com/apache/arrow-datafusion/pull/2261#discussion_r853256368
##########
datafusion/core/src/row/layout.rs:
##########
@@ -50,13 +118,23 @@ fn type_width(dt: &DataType) -> usize {
}
}
+fn word_aligned_offsets(null_width: usize, schema: &Arc<Schema>) ->
(Vec<usize>, usize) {
+ let mut offsets = vec![];
+ let mut offset = null_width;
+ for _ in schema.fields() {
+ offsets.push(offset);
+ offset += 8; // a 8-bytes word for each field
Review Comment:
It just seemed like a landmine for the future. It is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
