lidavidm commented on code in PR #12891:
URL: https://github.com/apache/arrow/pull/12891#discussion_r853417249
##########
cpp/src/arrow/util/vector.h:
##########
@@ -77,9 +77,14 @@ std::vector<T> ReplaceVectorElement(const std::vector<T>&
values, size_t index,
}
template <typename T, typename Predicate>
-std::vector<T> FilterVector(std::vector<T> values, Predicate&& predicate) {
- auto new_end =
- std::remove_if(values.begin(), values.end(),
std::forward<Predicate>(predicate));
+std::vector<T> FilterVector(std::vector<T> values, Predicate&& predicate,
+ std::vector<T>* filtered_out = NULLPTR) {
Review Comment:
It's not used indeed. But the change is still needed since it actually
inverts what FilterVector does! (The current FilterVector is backwards of what
you would expect…)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
