tustvold commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r853813924
##########
arrow/src/ipc/reader.rs:
##########
@@ -1444,32 +1444,31 @@ mod tests {
assert_eq!(input_batch, output_batch);
}
- #[test]
- fn test_roundtrip_stream_nested_dict_dict() {
- let values = StringArray::from_iter_values(["a", "b", "c"]);
- let keys = Int8Array::from_iter_values([0, 0, 1, 2, 0, 1]);
+ fn test_roundtrip_stream_dict_of_list_of_dict_impl<
+ OffsetSize: OffsetSizeTrait,
+ U: ArrowNativeType,
+ >(
+ list_data_type: DataType,
+ offsets: &[U; 5],
+ ) {
+ let values = StringArray::from(vec![Some("a"), None, Some("c"), None]);
Review Comment:
Whilst reviewing #1583 I realised this has the same bug, dictionaries store
nulls on the keys not the values. This might not be doing something sensible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
