AlenkaF commented on code in PR #12855:
URL: https://github.com/apache/arrow/pull/12855#discussion_r854082872
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -376,6 +376,21 @@ register_bindings_duration_helpers <- function() {
register_binding("dyears", function(x = 1) {
make_duration(x * 31557600, "s")
})
+ register_binding("dseconds", function(x = 1) {
+ make_duration(x, "s")
+ })
+ register_binding("dmilliseconds", function(x = 1) {
+ make_duration(x, "ms")
+ })
+ register_binding("dmicroseconds", function(x = 1) {
+ make_duration(x, "us")
+ })
+ register_binding("dnanoseconds", function(x = 1) {
+ make_duration(x, "ns")
+ })
+ register_binding("dpicoseconds", function(x = 1) {
+ abort("Duration in picoseconds not supported in Arrow.")
+ })
Review Comment:
Thanks @thisisnic for all the help! Will do a better job at asking questions
next time (reprex and such).
The code needs a bit of tweaking and will be ready to commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
