andygrove commented on code in PR #2283:
URL: https://github.com/apache/arrow-datafusion/pull/2283#discussion_r854418378
##########
datafusion/core/benches/jit.rs:
##########
@@ -23,9 +23,9 @@ extern crate datafusion;
mod data_utils;
use crate::criterion::Criterion;
use crate::data_utils::{create_record_batches, create_schema};
-use datafusion::row::jit::writer::bench_write_batch_jit;
Review Comment:
we could re-export the new crate from datafusion so we don't have to change
these imports - we are doing this for the other datafusion crates:
``` rust
// re-export DataFusion crates
pub use datafusion_common as common;
pub use datafusion_data_access;
pub use datafusion_expr as logical_expr;
pub use datafusion_physical_expr as physical_expr;
```
```
##########
datafusion/core/benches/jit.rs:
##########
@@ -23,9 +23,9 @@ extern crate datafusion;
mod data_utils;
use crate::criterion::Criterion;
use crate::data_utils::{create_record_batches, create_schema};
-use datafusion::row::jit::writer::bench_write_batch_jit;
Review Comment:
we could re-export the new crate from datafusion so we don't have to change
these imports - we are doing this for the other datafusion crates:
``` rust
// re-export DataFusion crates
pub use datafusion_common as common;
pub use datafusion_data_access;
pub use datafusion_expr as logical_expr;
pub use datafusion_physical_expr as physical_expr;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
