tustvold opened a new pull request, #2298: URL: https://github.com/apache/arrow-datafusion/pull/2298
# Rationale for this change #2261 added a test that elapsed_compute was recorded in metrics, unfortunately in the case of LocalLimitExec and GlobalLimitExec the operator body is too small to reliable take time, and as such this test is flaky * https://github.com/apache/arrow-datafusion/runs/6100177086?check_suite_focus=true * https://github.com/apache/arrow-datafusion/runs/6100277301?check_suite_focus=true * https://github.com/apache/arrow-datafusion/runs/6100969854?check_suite_focus=true Additionally when rendering plan metrics, a value if 0 is translated to "NOT RECORDED" - https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/src/physical_plan/metrics/value.rs#L540 # What changes are included in this PR? This changes `Time::add_duration` and `Time::add` to always record at least one nanosecond. # Are there any user-facing changes? Yes, calling `Timer::add_duration` will now always record at least 1 nanosecond -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
