jonkeane commented on code in PR #11666:
URL: https://github.com/apache/arrow/pull/11666#discussion_r854613446
##########
r/tools/nixlibs.R:
##########
@@ -301,8 +301,10 @@ build_libarrow <- function(src_dir, dst_dir) {
# EXTRA_CMAKE_FLAGS will often be "", but it's convenient later to have it
defined
EXTRA_CMAKE_FLAGS = Sys.getenv("EXTRA_CMAKE_FLAGS"),
# Make sure we build with the same compiler settings that R is using
- CC = R_CMD_config("CC"),
- CXX = paste(R_CMD_config("CXX11"), R_CMD_config("CXX11STD")),
+ # but we remove ccache, since `ARROW_USE_CCACHE` does that for our
dependencies, and
+ # having ccache here as well leads to compile errors
+ CC = gsub("^.*ccache", "", R_CMD_config("CC")),
+ CXX = paste(gsub("^.*ccache", "", R_CMD_config("CXX11")),
R_CMD_config("CXX11STD")),
Review Comment:
And you can see at
https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=23626&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=6c939d89-0d1a-51f2-8b30-091a7a82e98c&l=1501
that ccache is being used
```
...
ccache g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG
-I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-7.0.0.9000/include
-DARROW_R_WITH_ARROW -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET
-DARROW_R_WITH_S3 -DARROW_R_WITH_JSON
-I'/usr/local/lib/R/site-library/cpp11/include' -fpic -g -O2
-ffile-prefix-map=/build/r-base-lt88el/r-base-4.1.3=. -fstack-protector-strong
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -c
RTasks.cpp -o RTasks.o
ccache g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG
-I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-7.0.0.9000/include
-DARROW_R_WITH_ARROW -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET
-DARROW_R_WITH_S3 -DARROW_R_WITH_JSON
-I'/usr/local/lib/R/site-library/cpp11/include' -fpic -g -O2
-ffile-prefix-map=/build/r-base-lt88el/r-base-4.1.3=. -fstack-protector-strong
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -c
altrep.cpp -o altrep.o
ccache g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG
-I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-7.0.0.9000/include
-DARROW_R_WITH_ARROW -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET
-DARROW_R_WITH_S3 -DARROW_R_WITH_JSON
-I'/usr/local/lib/R/site-library/cpp11/include' -fpic -g -O2
-ffile-prefix-map=/build/r-base-lt88el/r-base-4.1.3=. -fstack-protector-strong
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -c
array.cpp -o array.o
ccache g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG
-I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-7.0.0.9000/include
-DARROW_R_WITH_ARROW -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET
-DARROW_R_WITH_S3 -DARROW_R_WITH_JSON
-I'/usr/local/lib/R/site-library/cpp11/include' -fpic -g -O2
-ffile-prefix-map=/build/r-base-lt88el/r-base-4.1.3=. -fstack-protector-strong
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -c
array_to_vector.cpp -o array_to_vector.o
ccache g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG
-I/arrow/r/check/arrow.Rcheck/00_pkg_src/arrow/libarrow/arrow-7.0.0.9000/include
-DARROW_R_WITH_ARROW -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET
-DARROW_R_WITH_S3 -DARROW_R_WITH_JSON
-I'/usr/local/lib/R/site-library/cpp11/include' -fpic -g -O2
-ffile-prefix-map=/build/r-base-lt88el/r-base-4.1.3=. -fstack-protector-strong
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -c
arraydata.cpp -o arraydata.o
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
