lidavidm commented on code in PR #12702:
URL: https://github.com/apache/arrow/pull/12702#discussion_r854688260
##########
cpp/src/arrow/util/tracing_internal.h:
##########
@@ -114,23 +116,44 @@ class SpanImpl {
opentelemetry::trace::StartSpanOptions SpanOptionsWithParent(
const util::tracing::Span& parent_span);
-#define START_SPAN(target_span, ...)
\
- auto opentelemetry_scope##__LINE__ =
\
- ::arrow::internal::tracing::GetTracer()->WithActiveSpan(
\
- target_span
\
- .Set(::arrow::util::tracing::Span::Impl{
\
-
::arrow::internal::tracing::GetTracer()->StartSpan(__VA_ARGS__)}) \
- .span)
-
-#define START_SPAN_WITH_PARENT(target_span, parent_span, ...)
\
- auto opentelemetry_scope##__LINE__ =
\
- ::arrow::internal::tracing::GetTracer()->WithActiveSpan(
\
- target_span
\
- .Set(::arrow::util::tracing::Span::Impl{
\
- ::arrow::internal::tracing::GetTracer()->StartSpan(
\
- __VA_ARGS__,
\
-
::arrow::internal::tracing::SpanOptionsWithParent(parent_span))}) \
- .span)
+#define CONFIGURE_TARGET_SPAN(target_span, ...) \
Review Comment:
I don't follow, these macros have repeated code right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
