emkornfield commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r855080340
##########
ci/scripts/python_wheel_unix_test.sh:
##########
@@ -67,6 +69,10 @@ import pyarrow.orc
import pyarrow.parquet
import pyarrow.plasma
"
+ if [ "${PYARROW_TEST_GCS}" == "ON" ]; then
+ pip install
https://github.com/googleapis/storage-testbench/archive/v0.16.0.tar.gz
Review Comment:
moved this. and used formulation suggested. it looks like wheel tests
failed in the last run due to not finding test_bench (symptom if
failures/timeouts when running builds).
##########
cpp/src/arrow/filesystem/gcsfs.h:
##########
@@ -27,11 +27,38 @@
namespace arrow {
namespace fs {
-struct GcsCredentials;
+// Opaque wrapper for GCS's library credentials to avoid exposing in Arrow
headers.
+struct GcsCredentialsHolder;
+class GcsFileSystem;
+
+/// \brief Container for GCS Credentials and information necessary to recreate
them.
+class GcsCredentials {
Review Comment:
added.
##########
dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh:
##########
@@ -18,6 +18,7 @@ else
export PYARROW_WITH_GANDIVA=1
fi
export PYARROW_WITH_HDFS=1
+export PYARROW_WITH_GCS=1
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
