pitrou commented on code in PR #12590:
URL: https://github.com/apache/arrow/pull/12590#discussion_r855149297
##########
cpp/src/arrow/datum.cc:
##########
@@ -279,4 +279,23 @@ void PrintTo(const Datum& datum, std::ostream* os) {
}
}
+std::string ToString(Datum::Kind kind) {
+ switch (kind) {
+ case Datum::NONE:
+ return "None";
+ case Datum::SCALAR:
+ return "Scalar";
+ case Datum::ARRAY:
+ return "Array";
+ case Datum::CHUNKED_ARRAY:
+ return "ChunkedArray";
+ case Datum::RECORD_BATCH:
+ return "RecordBatch";
+ case Datum::TABLE:
+ return "Table";
+ default:
+ return NULL;
Review Comment:
Or, rather, make sure this doesn't happen?
```suggestion
DCHECK(false);
return "";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
