rok commented on code in PR #12657:
URL: https://github.com/apache/arrow/pull/12657#discussion_r855168376
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -705,21 +721,75 @@ year_month_day GetFlooredYmd(int64_t arg, int multiple,
Localizer localizer_) {
} else {
total_months = (total_months - multiple + 1) / multiple * multiple;
}
- return year_month_day(year{1970} / jan / 0) + months{total_months};
+ return year{1970} / jan / 1 + months{total_months};
Review Comment:
Not really, just making it consistent with other places for readability.
AFAIK `year{1970} / jan / 1` == `year{1970} / jan / 0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
