pitrou commented on a change in pull request #7992:
URL: https://github.com/apache/arrow/pull/7992#discussion_r477340451
##########
File path: cpp/src/arrow/flight/internal.cc
##########
@@ -465,11 +465,9 @@ Status FromProto(const pb::SchemaResult& pb_result,
std::string* result) {
}
Status SchemaToString(const Schema& schema, std::string* out) {
- // TODO(wesm): Do we care about better memory efficiency here?
ipc::DictionaryMemo unused_dict_memo;
Review comment:
Hmm... since there seemed to be nothing concerning about memory
efficiency, I thought this TODO was obsolete. What did you have in mind when
writing it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
