lidavidm commented on code in PR #12941:
URL: https://github.com/apache/arrow/pull/12941#discussion_r855493600
##########
java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestClientMiddleware.java:
##########
@@ -84,6 +84,8 @@ public void testMultiValuedHeaders() {
});
// The server echoes the headers we send back to us, so ensure all the
ones we sent are present with the correct
// values in the correct order.
+ EXPECTED_BINARY_HEADERS.put("x-binary-bin", Arrays.asList(new byte[] {0},
new byte[]{1}));
+ EXPECTED_TEXT_HEADERS.put("x-text", Arrays.asList("foo", "bar"));
Review Comment:
Hmm, inline the declarations here too if they're only used in this test?
Else put the initialization in a `static` block
##########
java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java:
##########
@@ -346,7 +345,7 @@ public FlightInfo getExportedKeys(final TableRef tableRef,
final CallOption... o
}
Objects.requireNonNull(tableRef.getTable());
- builder.setTable(tableRef.getTable()).build();
Review Comment:
It seems the right fix should be to just remove `.build`? Or else, inline it
below or pull out some code? e.g.
`Any command = Any.pack(builder.setTable(...).build());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
