lidavidm commented on code in PR #12852:
URL: https://github.com/apache/arrow/pull/12852#discussion_r856376046
##########
cpp/src/arrow/engine/substrait/extension_set.h:
##########
@@ -226,14 +246,10 @@ class ARROW_ENGINE_EXPORT ExtensionSet {
private:
ExtensionIdRegistry* registry_;
/// The subset of extension registry URIs referenced by this extension set
- std::vector<util::string_view> uris_;
+ std::unordered_map<uint32_t, util::string_view> uris_;
std::vector<TypeRecord> types_;
-
std::vector<FunctionRecord> functions_;
-
- // pimpl pattern to hide lookup details
- struct Impl;
- std::unique_ptr<Impl, void (*)(Impl*)> impl_;
+ std::unordered_map<Id, uint32_t, IdHashEq, IdHashEq> types_map_,
functions_map_;
Review Comment:
I don't think we have a real guideline. IdHashEq could indeed be useful, but
unordered_map is a "heavy" include to have (that said we lost that battle a
long time ago). I don't think we have to hide this, though, just wondering if
it's useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
