tfeda commented on code in PR #1612:
URL: https://github.com/apache/arrow-rs/pull/1612#discussion_r857038398


##########
parquet/src/arrow/schema.rs:
##########
@@ -678,20 +678,20 @@ impl ParquetTypeConverter<'_> {
                 (32, false) => Ok(DataType::UInt32),
                 _ => Err(ArrowError(format!(
                     "Cannot create INT32 physical type from {:?}",
-                    t
+                    self.schema.get_basic_info().logical_type(), 

Review Comment:
   Ahhhh I missed the ref, thanks. Adding a ref seemed better than deriving 
Copy for LogicalType, TimeUnit, MilliSeconds, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to