liyafan82 commented on a change in pull request #8036:
URL: https://github.com/apache/arrow/pull/8036#discussion_r478277035
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -191,8 +193,15 @@ struct Divide {
template <typename T, typename Arg0, typename Arg1>
static enable_if_floating_point<T> Call(KernelContext* ctx, Arg0 left, Arg1
right) {
if (ARROW_PREDICT_FALSE(right == 0)) {
Review comment:
After changing the code, the AMD64 Ubuntu 18.04 C++ ASAN UBSAN
integration test is failing again.
It seems this is a bug of clang, and some special flags are required:
https://bugs.llvm.org/show_bug.cgi?id=17000#c1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
