zhztheplayer commented on code in PR #10883:
URL: https://github.com/apache/arrow/pull/10883#discussion_r857728591
##########
cpp/src/jni/dataset/jni_wrapper.cc:
##########
@@ -458,25 +416,21 @@
Java_org_apache_arrow_dataset_jni_JniWrapper_getSchemaFromScanner(JNIEnv* env, j
/*
* Class: org_apache_arrow_dataset_jni_JniWrapper
* Method: nextRecordBatch
- * Signature: (J)Lorg/apache/arrow/dataset/jni/NativeRecordBatchHandle;
+ * Signature: (JJ)Z
*/
-JNIEXPORT jobject JNICALL
Java_org_apache_arrow_dataset_jni_JniWrapper_nextRecordBatch(
- JNIEnv* env, jobject, jlong scanner_id) {
+JNIEXPORT jboolean JNICALL
Java_org_apache_arrow_dataset_jni_JniWrapper_nextRecordBatch(
+ JNIEnv* env, jobject, jlong scanner_id, jlong struct_array) {
JNI_METHOD_START
std::shared_ptr<DisposableScannerAdaptor> scanner_adaptor =
RetrieveNativeInstance<DisposableScannerAdaptor>(scanner_id);
std::shared_ptr<arrow::RecordBatch> record_batch =
JniGetOrThrow(scanner_adaptor->Next());
if (record_batch == nullptr) {
- return nullptr; // stream ended
+ return false; // stream ended
}
- std::shared_ptr<arrow::Schema> schema = record_batch->schema();
- jobjectArray field_array =
- env->NewObjectArray(schema->num_fields(),
record_batch_handle_field_class, nullptr);
-
- std::vector<std::shared_ptr<arrow::Buffer>> buffers;
- for (int i = 0; i < schema->num_fields(); ++i) {
+ std::vector<std::shared_ptr<arrow::Array>> offset_zeroed_arrays;
+ for (int i = 0; i < record_batch->num_columns(); ++i) {
// TODO: If the array has an offset then we need to de-offset the array
Review Comment:
It's still valid. The codes still copy and rebuild offset-buffers because
Java C Data Interface doesn't implement exporing/importing for offset-buffers
too. And I believe to do that we should make systematic change to Java code
since Arrow Java didn't implement the same offset semantic comparing to C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
